https://bugzilla.redhat.com/show_bug.cgi?id=2222844 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |fedora@xxxxxxxxxx --- Comment #6 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > %install > mkdir -p %{buildroot}/%{_includedir} > cp qoi.h %{buildroot}/%{_includedir} 1. You should aim to preserve file timestamps. You can use "cp -a" or "cp --preserve=timestamps". https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps 2. Using "cp" is fine, but I think that most .spec files use "install" instead. "install -d" can also be used to create directories. > %files devel > %license LICENSE > %doc README.md The -devel package has a hard "Requires:" on the base package, so these files can be omitted. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing Also, looking at the copr build made by the review service: > gcc -std=c99 -O3 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer qoiconv.c -o qoiconv This does not include Fedora's LDFLAGS. You'll need to either modify the Makefile to include those in the gcc invocation, or call the compiler manually. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2222844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202222844%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
