Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbxml - An embeddable XML database https://bugzilla.redhat.com/show_bug.cgi?id=250093 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-01-05 11:04 EST ------- Almost okay. For 2.3.10-9: * EVR specific Requires between subpackages - Usually the dependency between subpackages must be EVR (Epoch-Version-Release) specific, not just Version. i.e. dbxml-utils must have "Requires: %{name} = %{version}-%{release}", for example. * Parallel make - Support parallel make if possible, otherwise please comment about not supporting parallel make. * Timestamps - Please try to keep timestamps on installed files when possible. * Please use "-p" option when using "cp" or "install" commands * Defattr - We now recommend %defattr(-,root,root,-) * Undefined non-weak symbol - "$ rpmlint dbxml" returns lots of undefined non-weak symbols ! Note rpmlint can be used for installed rpm. You can also check this by $ ldd -r /usr/lib/libdbxml-2.3.so (on i386) For this package this cannot be ignored because this package provides -devel subpackage and these symbols causes linkage failure. Perhaps libdbxml-2.3.so must be linked agaist some more libraries. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review