https://bugzilla.redhat.com/show_bug.cgi?id=2213321 --- Comment #4 from Link Dupont <link@xxxxxxxxxxx> --- It looks like the fact that github.com/hebcal/hebcal-go and github.com/hebcal/hebcal are separate Go packages is confusing golist. When I run golist without --skip-self, it includes the github.com/hebcal/hebcal-go package requirements: link@thelio:~/.../hebcal/hebcal$ golist --imported --package-path $goipath github.com/hebcal/greg github.com/hebcal/hdate github.com/hebcal/hebcal-go/event github.com/hebcal/hebcal-go/hebcal github.com/hebcal/hebcal-go/locales github.com/hebcal/hebcal-go/yerushalmi github.com/hebcal/hebcal-go/zmanim github.com/pborman/getopt/v2 However, when run with --skip-self (as golist is run by the %go_generate_buildrequires macro), it incorrectly assumes those packages are local: link@thelio:~/.../hebcal/hebcal$ golist --imported --package-path $goipath --skip-self github.com/hebcal/greg github.com/hebcal/hdate github.com/pborman/getopt/v2 Ideally, the right solution here is for upstream to move github.com/hebcal/hebcal into a package within github.com/hebcal/hebcal-go (using the cmd/hebcal convention). Then one RPM would provide both the github.com/hebcal/hebcal-go source files, and then resulting github.com/hebcal/hebcal-go/cmd/hebcal binary. Maybe make a note by the manual BuildRequires: line that notes why that requirement is present. Alternatively, you could forgo using %go_generate_buildrequires and use a manual list. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_automatic_dependency_generation for an example of using golist manually. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2213321 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202213321%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
