https://bugzilla.redhat.com/show_bug.cgi?id=2222023 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you for the review! (In reply to Didik Supriadi from comment #2) > > [?]: Package must own all directories that it creates. > > Note: Directories without known owners: /etc/ant.d > > I'm not sure about this one. /etc/ant.d is currently owned by ant. Hmmm, apache-commons-vfs-ant does not have "Requires: ant". I think that is wrong. I have added it. > > [!]: %config files are marked noreplace or the reason is justified. > > Note: No (noreplace) in %config /etc/ant.d/commons-vfs > > Do you think it would be appropriate to use '%config(noreplace)' in this > context? > (I'm not entirely sure in my own judgment) I'm not sure either, but I added it. > > [!]: Macros in Summary, %description expandable at SRPM build time. > > Note: Macros in: apache-commons-vfs (description) > > the warning is shown below. > moving %javadoc_package macro to a position immediately preceding %prep > should fix it. Thanks! I have moved it. I have uploaded new spec and srpm files to the same URLs as before. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2222023 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202222023%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
