https://bugzilla.redhat.com/show_bug.cgi?id=2222367 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Quick comments from Rust point of view: - outdated BuildRequires: "BuildRequires: rust-packaging" is obsolete, that package no longer exists. Use "cargo-rpm-macros" instead (which Provides: "rust-packaging" now for backwards compatibility). - license information is generated but discarded You correctly collect license information for statically linked Rust components: > %cargo_license_summary > %{cargo_license} > LICENSES.dependencies But this information is then unused and discarded. The LICENSE(S).dependencies file should be marked as %license (not sure if the %pyproject_save_files thing recognises it, probably not), and the output of the %cargo_license_summary macro should also be used to full the value of the License tag of the "python3-rpds-py" sub-package (which is missing). You can take a look at rpm-sequoia for an example of what's currently considered "best practice": https://src.fedoraproject.org/rpms/rust-rpm-sequoia/blob/rawhide/f/rust-rpm-sequoia.spec#_25-38 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2222367 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202222367%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
