[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1877006



--- Comment #49 from Petr Pisar <ppisar@xxxxxxxxxx> ---
$ rpmlint smf-spf.spec ../SRPMS/smf-spf-2.5.1^20220423g061e937-1.fc39.src.rpm
../RPMS/x86_64/smf-spf-*
======================================== rpmlint session starts
=======================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 5

smf-spf.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/smfs.conf
smf-spf.x86_64: W: non-standard-uid /run/smfs smfs
smf-spf.x86_64: W: non-standard-gid /run/smfs smfs
smf-spf.x86_64: E: non-standard-dir-perm /run/smfs 700
smf-spf.x86_64: W: no-manual-page-for-binary smf-spf
smf-spf.x86_64: E: file-parent-ownership-mismatch Path "/run/smfs/smf-spf.sock"
owned by "root" is stored in directory owned by "smfs"
========= 4 packages and 1 specfiles checked; 2 errors, 4 warnings, 2 badness;
has taken 0.3 s ========
rpmlint is OK.

The package builds in F39
(https://koji.fedoraproject.org/koji/taskinfo?taskID=103262450). Ok.

/run/smfs is installed with a proper owner. Ok.
/run/smfs is created after a reboot with a proper owner. Ok.
smf-spf.service starts successfully. Ok.


After starting the daemon, RPM verification fails:

# ls -la /run/smfs/
total 0
drwx------.  2 smfs smfs  60 Jul 12 11:57 .
drwxr-xr-x. 25 root root 660 Jul 12 11:55 ..
srw-------.  1 smfs smfs   0 Jul 12 11:57 smf-spf.sock
(reverse-i-search)`ve': dnf5 --disablerepo=rawhide --enablerepo=f39-build
remo^C sendmail
# rpm -V smf-spf
.M...UG..  g /run/smfs/smf-spf.sock

The reason is that the daemon deletes the socket and recreates it with a
different ownership, mode and timestamp. Compare to the packaged data:

$ rpm -q -lv -p ../RPMS/x86_64/smf-spf-2.5.1^20220423g061e937-1.fc39.x86_64.rpm
| grep smf-spf.sock
-rw-r--r--    1 root     root                        0 Jul 12 02:00
/run/smfs/smf-spf.sock

FIX: Package the socket file with %attr(0600,smfs,smfs).

Please correct this last issue.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1877006

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201877006%23c49
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux