https://bugzilla.redhat.com/show_bug.cgi?id=2216600 --- Comment #15 from Felix Wang <topazus@xxxxxxxxxxx> --- Thanks for the checking. > I think the License should include an “AND LGPL-2.0-or-later” term for src/qml/elements/IconTopButton.qml. Could you explain why? I see the file src/qml/elements/IconTopButton.qml is licensed under GPL-3.0-or-later. https://invent.kde.org/network/kaidan/-/blob/master/src/qml/elements/IconTopButton.qml > The files src/hsluv-c/hsluv.h and src/hsluv-c/hsluv.c are a bundled copy of http://github.com/hsluv/hsluv-c. This is designed as a ”copylib” and doesn’t have an upstream build system for a separate library, so it’s unlikely it can be separately packaged for Fedora. However, it still needs to be handled in accordance with https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling. At minimum, the appropriate virtual Provides should be added. I will add the hsluv-c as the bundled library. Also, I noticed that the source code files at src/singleapp directory are the bundled library of SingleApplication, https://github.com/itay-grudev/SingleApplication. I will add this too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2216600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202216600%23c15 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
