Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Package review: emesene Alias: emesene https://bugzilla.redhat.com/show_bug.cgi?id=238379 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(tibbs@xxxxxxxxxxx)| ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-01-04 20:49 EST ------- Unfortunately when you set tickets to needinfo they drop way down to the bottom of the bugzilla front page, so this ticket managed to escape my notice when I had free time over the holidays. Also unfortunately, the package in comment 24 fails to build: + desktop-file-install --dir /var/tmp/emesene-1.0-1.fc9-root-mockbuild/usr/share/applications/builddir/build/SOURCES/emesene.desktop /var/tmp/rpm-tmp.97273: line 36: desktop-file-install: command not found error: Bad exit status from /var/tmp/rpm-tmp.97273 (%install) This is because you need a build-time dependency on desktop-file-utils, not a runtime dependency. So change Requires: desktop-file-utils to BuildRequires: desktop-file-utils Now, that gets things building. But we're still left with some issues: emesene.noarch: E: non-executable-script /usr/share/emesene/desktop.py 0644 emesene.noarch: E: non-executable-script /usr/share/emesene/Controller.py 0644 > It is intentionally by author which user should run it by the executable > 'emesene'. OK, we'll just ignore those but perhaps you should ask upstream why these are set up as proper scripts to be executed with #! lines but aren't supposed to be executable. emesene.noarch: W: summary-ended-with-dot A platform independent instant messaging client for the Windows Live Messenger (tm) network. emesene.noarch: E: summary-too-long A platform independent instant messaging client for the Windows Live Messenger (tm) network. These seem to be new; summary lines aren't sentences and don't end with periods, and the summary needs to be shorter than 80 characters. Why not just: Instant messaging client for hte Windows Live Messenger (tm) network Platform independence doesn't really matter for a Fedora package, since the package itself obviously isn't. emesene.noarch: E: description-line-too-long emesene is a platform independent instant messaging client for the Windows Live Messenger (tm) network. Lines in %description need to wrap at 80 characters as well. emesene.noarch: W: file-not-in-%lang /usr/share/emesene/po/ar/LC_MESSAGES/emesen.mo (and several others) I figured out what the problem is here. It's complaining that you're not doing %lang(ar) %{_datadir}/emesene/po/ar and so on for each of the directories files in your %files section. That seems like a significant pain, but this package doesn't use the regular location for locale files and so can't use the standard %find_lang macro. Unfortunately this does make your %files list quite a bit more complicated since you have to list everything under %{appdir} separately (or construct a glob that doesn't include the po directory, but don't forget to include the po directory itself as %dir %{appdir}/po). Also, note that the Arabic .mo file seems to be missing an 'e' in its name. I don't know if that's a problem. emesene.noarch: W: empty-%post Don't just add %{nil}, which still results in an empty %post. Remove %post altogether. Generally there's no point to empty sections (except for %build, which has in the past caused some oddities when it's missing). Finally, I'm not sure I understand why you have %verify(not md5 size mtime) %{_bindir}/emesene in your %files list. What about that script is expected to change? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review