https://bugzilla.redhat.com/show_bug.cgi?id=2179213 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- Url and Source0 addresses are Ok. Source0 (SHA-512: c01b7c4184901955bff82aaeef0cde7f0b613e6ebff1158b3603f2835e13590a9353920a430598a3cde5c305a7316a78e302186bf4d3bf458133262578b42eb3) is original. Ok. Summary verified from README.rst. Ok. Description verified from README.rst. Ok. TODO: Spell "pulseaudio" as "PulseAudio". That's what the sound server is called like. License verified from src/pulseaudio.hh, src/pulseaudio.cc, src/pamixer.cc, src/device.hh, src/device.cc, COPYING. Ok. FIX: Build-require 'cxxopts-static' instead of (or in addition to) 'pkgconfig(cxxopts)'. cxxopts is a header-only library <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries>. No tests, no %check phase. Ok. $ rpmlint pamixer.spec ../SRPMS/pamixer-1.6-1.fc39.src.rpm ../RPMS/x86_64/pamixer-* ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 5 ========= 4 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s ======== rpmlint output is Ok. $ rpm -q -lv -p ../RPMS/x86_64/pamixer-1.6-1.fc39.x86_64.rpm -rwxr-xr-x 1 root root 276048 Jul 11 02:00 /usr/bin/pamixer drwxr-xr-x 2 root root 0 Jul 11 02:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Jul 11 02:00 /usr/lib/.build-id/da lrwxrwxrwx 1 root root 27 Jul 11 02:00 /usr/lib/.build-id/da/b15c9ffffaeff9718ba00bce19fde43a7b98a7 -> ../../../../usr/bin/pamixer drwxr-xr-x 2 root root 0 Jul 11 02:00 /usr/share/doc/pamixer -rw-r--r-- 1 root root 2469 Jun 10 2022 /usr/share/doc/pamixer/README.rst drwxr-xr-x 2 root root 0 Jul 11 02:00 /usr/share/licenses/pamixer -rw-r--r-- 1 root root 35147 Jun 10 2022 /usr/share/licenses/pamixer/COPYING -rw-r--r-- 1 root root 668 Jun 10 2022 /usr/share/man/man1/pamixer.1.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/pamixer-1.6-1.fc39.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.32)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libgcc_s.so.1()(64bit) 1 libgcc_s.so.1(GCC_3.0)(64bit) 1 libgcc_s.so.1(GCC_3.3.1)(64bit) 1 libm.so.6()(64bit) 1 libm.so.6(GLIBC_2.2.5)(64bit) 1 libm.so.6(GLIBC_2.29)(64bit) 1 libpulse.so.0()(64bit) 1 libpulse.so.0(PULSE_0)(64bit) 1 libstdc++.so.6()(64bit) 1 libstdc++.so.6(CXXABI_1.3)(64bit) 1 libstdc++.so.6(CXXABI_1.3.5)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.11)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.14)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.15)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.18)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.21)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.29)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.30)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.32)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.9)(64bit) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/pamixer-1.6-1.fc39.x86_64.rpm | sort -f | uniq -c 1 pamixer = 1.6-1.fc39 1 pamixer(x86-64) = 1.6-1.fc39 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/pamixer-1.6-1.fc39.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 39 (https://koji.fedoraproject.org/koji/taskinfo?taskID=103219128). Ok. Otherwise the package is in line with Fedora, Meson, and C++ packaging guidelines. Please correct the FIX item and provide an updated spec file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2179213 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202179213%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
