https://bugzilla.redhat.com/show_bug.cgi?id=2211754 --- Comment #9 from Jakub Jelen <jjelen@xxxxxxxxxx> --- I see you updated the version in the header, but did not add a changelog entry with the 0.2 version. I think we need this. I still see the "too unspecific glob" in the mandir `%{_mandir}/man7/*` pointed by Petr in comment #3 As mentioned in the comment #1, the signed releases are now provided [1] so it would be good to use the signatures. This just a nit. Spec file mentiones 3.0.5 as smallest openssl version, but upstream configure requires 3.0.7 [2]: > BuildRequires: openssl-devel >= 3.0.5 [1] https://github.com/latchset/pkcs11-provider/issues/248 [2] https://github.com/latchset/pkcs11-provider/blob/main/configure.ac#L71 Running the fedora review now, but I believe with the above fixed, there will be no other issues. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2211754 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202211754%23c9 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
