https://bugzilla.redhat.com/show_bug.cgi?id=2221418 --- Comment #4 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> --- > So at least /Source needs be in the python3-tensile My gut says that everything should be in the devel package, as it seems like tensile is a python tool inter-tangled with a static library. > The use /opt/rocm/bin/hipcc needs to change /usr/bin/hipcc or just hipcc and assume PATH will find it Ack, I should probably look to see what Debian did, so I can reduce some back and forth. > why the license and readme needed in the -devel package ? It was a mistake, I'll fix it. > i am not sure about the miopen configs either, miopen needs blas and blas need this.. > let's not over think it and add them back if there is a problem. Yeah I can just drop the "rm" later. It's mostly duplicated files, so I'd rather exclude it unless it's clear we need it. > check is an option, but Tests/ is always installed, should installing Tests/ follow the check option ? I'm not sure if the tests are used for rocblas tests yet. In the meantime, I can do the same as the miopen archives and remove it for now. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2221418 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202221418%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
