https://bugzilla.redhat.com/show_bug.cgi?id=2221357 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |POST Flags| |fedora-review+ --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MPL-2.0) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Minor nit-pick: Please add a comment to the Patch in the spec file (something like "criterion dependency is used only for running benchmarks, which does not happen during package builds, tests that use compiletest_rs are not included in published sources, ...). Hint for future Rust packages: I strongly recommend using rust2rpm's "-p" flag for patching Cargo.toml files. This happens so frequently that it's mostly automated. Also, some changes to Cargo.toml metadata will trigger changes to how the spec file is generated, so making these changes manually *after* the spec is already generated will lead to a spec file that is out of sync with the actual package contents. When using "rust2rpm -p", changes to Cargo.toml are taken into account when generating the spec file. Hint number two: Use the "-s" flag for rust2rpm. It saves you from having to run "spectool -g" separately. :) Welcome to Rust packaging! 😅 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2221357 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202221357%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
