https://bugzilla.redhat.com/show_bug.cgi?id=2183981 --- Comment #4 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > Reading the file, expect it should just be GPL v2 or later, LGPL v2.1 or later seems to apply only if used > outside of Doom, BSD3-Clause seems to have an additional clause: The clause mentions GZDoom specifically, and DSDA-Doom, being based on PrBoom+, is not a GZDoom fork. I guess one might ask the question "what qualifies as a derivative"? > Maybe check with legal as well since license modifications generally need checking: This file was already present in prboom+ and there were no issues there, but given the question above, asking legal won't hurt. > c) There seem to be some old tests which use rtest. Might it be possible to enable these? > They are not enabled in GitHub CI, so maybe they should be removed or updated. You mean the stuff inside `spec/`? The problem with those is that they require commercial DOOM .wad files to function. *Maybe* the tests using Valiant and Rush wads could be run. d) Should the icon also be setup used by the desktop file? Sorry, I don't understand what you mean. e) Should the desktop file be validated? It is. "desktop-file-install" validates the file before installing. Calling "desktop-file-validate" separately is needed only when installing through some other method. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2183981 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202183981%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
