https://bugzilla.redhat.com/show_bug.cgi?id=2216600 --- Comment #3 from Felix Wang <topazus@xxxxxxxxxxx> --- > First, add the following as a build dependancy: > BuildRequires: kf5-rpm-macros > %build > %cmake_kf5 > %cmake_build > Next, those should be added as requirements. I have a couple packages myself built for KDE and I was instructed to add this for packages using the QML module:> > # QML module dependencies > Requires: kf5-kirigami2%{?_isa} > Requires: kf5-kirigami2-addons%{?_isa} > Requires: kf5-kquickcharts%{?_isa} > Requires: qt5-qtgraphicaleffects%{?_isa} > Requires: qt5-qtquickcontrols2%{?_isa} > Requires: qt5-qtwebchannel%{?_isa} > Requires: qt5-qtwebengine%{?_isa} Done. > Next, under files, replace: > %{_datadir}/icons/hicolor/*/apps/%{name}.* > with: > %{_datadir}/icons/hicolor/128x128/apps/kaidan.png > %{_datadir}/icons/hicolor/scalable/apps/kaidan.svg > Reason: For shared folders, you should not be using wildcards (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists) I see the posted link, it seemed it said that it should not use wilcards to include all files of a directory. Anyway, it is a proper suggestion and can explicitly list all files in the directory. > Packagers SHOULD NOT simply glob everything under a shared directory. > In particular, the following SHOULD NOT be used in %files: > %{_bindir}/* > %{_datadir}/* > %{_includedir}/* > %{_mandir}/* > %{_docdir}/* > Lastly, the Source0 should use the KDE invent tags system, specially if Kaidan ever becomes part of the KDE gear. In this > case, it would look something like: > Source0: https://invent.kde.org/network/%{name}/-/archive/v%{version}/%{name}-v%{version}.tar.gz Done. > %if 0%{?fedora} || 0%{?epel} > 7 > # handled by qt5-srpm-macros, which defines %%qt5_qtwebengine_arches > # Package doesn't build on arches that qtwebengine is not built on. > ExclusiveArch: %{qt5_qtwebengine_arches} > %endif Added this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2216600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202216600%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
