https://bugzilla.redhat.com/show_bug.cgi?id=2216600 Steve Cossette <farchord@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |farchord@xxxxxxxxx CC| |farchord@xxxxxxxxx --- Comment #1 from Steve Cossette <farchord@xxxxxxxxx> --- Some early cleanup stuff I found in the spec: First, add the following as a build dependancy: BuildRequires: kf5-rpm-macros Then, replace: %build %cmake \ -GNinja \ -DCMAKE_BUILD_TYPE=Release \ -DUSE_KNOTIFICATIONS=ON \ -DBUILD_TESTS=ON \ %cmake_build With: %build %cmake_kf5 %cmake_build Next, those should be added as requirements. I have a couple packages myself built for KDE and I was instructed to add this for packages using the QML module: # QML module dependencies Requires: kf5-kirigami2%{?_isa} Requires: kf5-kirigami2-addons%{?_isa} Requires: kf5-kquickcharts%{?_isa} Requires: qt5-qtgraphicaleffects%{?_isa} Requires: qt5-qtquickcontrols2%{?_isa} Requires: qt5-qtwebchannel%{?_isa} Requires: qt5-qtwebengine%{?_isa} Next, under files, replace: %{_datadir}/icons/hicolor/*/apps/%{name}.* with: %{_datadir}/icons/hicolor/128x128/apps/kaidan.png %{_datadir}/icons/hicolor/scalable/apps/kaidan.svg Reason: For shared folders, you should not be using wildcards (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists) Lastly, the Source0 should use the KDE invent tags system, specially if Kaidan ever becomes part of the KDE gear. In this case, it would look something like: Source0: https://invent.kde.org/network/%{name}/-/archive/v%{version}/%{name}-v%{version}.tar.gz -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2216600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202216600%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
