https://bugzilla.redhat.com/show_bug.cgi?id=2168538 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) | --- Comment #21 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "FSF All Permissive License", "BSD 3-Clause License", "*No copyright* GNU Library General Public License v2 or later [obsolete FSF postal address (Temple Place)]", "GNU Library General Public License v2 or later [generated file, obsolete FSF postal address (Temple Place)]", "FSF Unlimited License (with License Retention) [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "FSF Unlimited License (with License Retention)", "FSF Unlimited License [generated file]", "X11 License [generated file]", "BSD 2-Clause License", "GNU General Public License v2.0 or later", "BSD 3-Clause License GNU General Public License, Version 2", "[generated file]", "*No copyright* [generated file]", "FSF Unlimited License (with License Retention) GNU Lesser General Public License GNU General Public License". 45 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/minidlna/2168538-minidlna/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/logrotate.d(bes, samba- common, psad, sssd-common, wpa_supplicant, below, macromilter, lightdm, yast2-filesystem, ppp, cepces, copr-dist-git, gerbera, kdm- settings, proftpd, logrotate, retrace-server, ntpsec, openqa) [x]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in minidlna [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: minidlna-1.3.3-1.fc38.x86_64.rpm minidlna-debuginfo-1.3.3-1.fc38.x86_64.rpm minidlna-debugsource-1.3.3-1.fc38.x86_64.rpm minidlna-1.3.3-1.fc38.src.rpm ==================================================== rpmlint session starts ==================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpmhcrxfq2')] checks: 31, packages: 4 minidlna.x86_64: W: non-standard-uid /etc/minidlna.conf minidlna minidlna.x86_64: W: non-standard-uid /run/minidlna minidlna minidlna.x86_64: W: non-standard-uid /var/cache/minidlna minidlna minidlna.x86_64: W: non-standard-uid /var/log/minidlna minidlna minidlna.x86_64: W: non-standard-gid /etc/minidlna.conf minidlna minidlna.x86_64: W: non-standard-gid /run/minidlna minidlna minidlna.x86_64: W: non-standard-gid /var/cache/minidlna minidlna minidlna.x86_64: W: non-standard-gid /var/log/minidlna minidlna minidlna.x86_64: E: missing-dependency-to-logrotate for logrotate script /etc/logrotate.d/minidlna minidlna.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/minidlnad ===================== 4 packages and 0 specfiles checked; 2 errors, 8 warnings, 2 badness; has taken 3.7 s ===================== Rpmlint (debuginfo) ------------------- Checking: minidlna-debuginfo-1.3.3-1.fc38.x86_64.rpm ==================================================== rpmlint session starts ==================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpe20fb8o3')] checks: 31, packages: 1 ===================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.5 s ===================== Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 minidlna.x86_64: W: non-standard-uid /etc/minidlna.conf minidlna minidlna.x86_64: W: non-standard-uid /run/minidlna minidlna minidlna.x86_64: W: non-standard-uid /var/cache/minidlna minidlna minidlna.x86_64: W: non-standard-uid /var/log/minidlna minidlna minidlna.x86_64: W: non-standard-gid /etc/minidlna.conf minidlna minidlna.x86_64: W: non-standard-gid /run/minidlna minidlna minidlna.x86_64: W: non-standard-gid /var/cache/minidlna minidlna minidlna.x86_64: W: non-standard-gid /var/log/minidlna minidlna minidlna.x86_64: E: missing-dependency-to-logrotate for logrotate script /etc/logrotate.d/minidlna minidlna.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/minidlnad 3 packages and 0 specfiles checked; 2 errors, 8 warnings, 2 badness; has taken 7.1 s Source checksums ---------------- http://downloads.sourceforge.net/minidlna/1.3.3/minidlna-1.3.3.tar.gz : CHECKSUM(SHA256) this package : 39026c6d4a139b9180192d1c37225aa3376fdf4f1a74d7debbdbb693d996afa4 CHECKSUM(SHA256) upstream package : 39026c6d4a139b9180192d1c37225aa3376fdf4f1a74d7debbdbb693d996afa4 Requires -------- minidlna (rpmlib, GLIBC filtered): /bin/sh config(minidlna) libFLAC.so.12()(64bit) libavahi-client.so.3()(64bit) libavahi-common.so.3()(64bit) libavformat.so.60()(64bit) libavformat.so.60(LIBAVFORMAT_60)(64bit) libavutil.so.58()(64bit) libavutil.so.58(LIBAVUTIL_58)(64bit) libc.so.6()(64bit) libexif.so.12()(64bit) libid3tag.so.0()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libogg.so.0()(64bit) libsqlite3.so.0()(64bit) libvorbis.so.0()(64bit) rtld(GNU_HASH) shadow-utils systemd minidlna-debuginfo (rpmlib, GLIBC filtered): minidlna-debugsource (rpmlib, GLIBC filtered): Provides -------- minidlna: config(minidlna) group(minidlna) minidlna minidlna(x86-64) user(minidlna) minidlna-debuginfo: debuginfo(build-id) minidlna-debuginfo minidlna-debuginfo(x86-64) minidlna-debugsource: minidlna-debugsource minidlna-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2168538 -m fedora-38-x86_64 Buildroot used: fedora-38-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Ocaml, Java, Python, Haskell, R, SugarActivity, Perl, fonts, PHP, Ruby Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Any response from upstream on "E: missing-call-to-setgroups-before-setuid" ? tried using setreuid and setregid instead, error message no longer appears https://download.copr.fedorainfracloud.org/results/fed500/minidlna/fedora-38-aarch64/06142705-minidlna/fedora-review/review.txt https://security.stackexchange.com/questions/122141/always-setgroups-before-setuid https://www.oreilly.com/library/view/secure-programming-cookbook/0596003943/ch01s03.html https://wiki.sei.cmu.edu/confluence/display/c/POS36-C.+Observe+correct+revocation+order+while+relinquishing+privileges From https://www.ibm.com/docs/en/aix/7.2?topic=s-setuid-setruid-seteuid-setreuid-setuidx-subroutine Perhaps check with upstream if this is ok b) Builds on all architectures https://copr.fedorainfracloud.org/coprs/fed500/minidlna/build/6142608/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2168538 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202168538%23c21 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
