Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bless - High quality, full featured hex editor https://bugzilla.redhat.com/show_bug.cgi?id=427226 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-01-04 09:43 EST ------- Review: + package builds in mock (rawhide i386). - rpmlint is NOT silent for RPM But Silent for SRPM. bless.i386: E: only-non-binary-in-usr-lib bless.i386: E: no-binary ==> This is ok as per mono packaging guidelines. + source files match upstream. 2f395e0b0c82382c49864947aea894ca bless-0.5.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present in separate -doc subpackage. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop files handled correctly. + scrollkeeper scriptlets are used. +GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review