https://bugzilla.redhat.com/show_bug.cgi?id=2217097 Jeremy Newton <alexjnewt@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: rocm-smi - |rocm_smi_lib - ROCm System |ROCm System Management |Management Interface |Interface Library |Library | --- Comment #12 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> --- Ok so I think I'm happy with it now. I had an extensive email conversation with upstream and we've agreed on taking in some proposed patches from me (plus the one from Tom). Regarding the SOVERSION, they don't plan on bumping this any time soon, or at all for that matter, ast heir goal is actually to merge a bunch of tools together into a project called amdsmi: https://github.com/RadeonOpenCompute/amdsmi With that said, they agreed it's better to maintain it in cmake rather than git tags. As far as I know, they're still a ways out before deprecating rocm-smi, but I'll need to keep that in mind for later. There's been some shift of ownership, as smi wasn't really maintained by a dedicated group for a while, so they're still getting things working, such as mirroring over their development branch to github, pulling github requests, etc. They've accepted more or less all the patches attached to this package as far as I know, so we can move forward now: Spec URL: https://mystro256.fedorapeople.org/rocm-smi.spec SRPM URL: https://mystro256.fedorapeople.org/rocm-smi-5.6.0-1.fc39.src.rpm COPR BUILD: https://copr.fedorainfracloud.org/coprs/mystro256/rocm-hip/build/6130687/ let me know if there's anything else outstanding. FYI fedora-review complains about this: - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rocm-smi See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names But obviously this is intended. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2217097 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202217097%23c12 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
