https://bugzilla.redhat.com/show_bug.cgi?id=2216561 Link Dupont <link@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #2 from Link Dupont <link@xxxxxxxxxxx> --- - [x] The spec file is clear and easy to read - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No rpmlint errors (or valid justification for exceptions) - [x] %check section passes - [x] The latest version is packaged - [x] %goipath is set correctly - [x] The package complies with the Packaging Guidelines Package approved, but consider updating golang-github-jarcoal-httpmock to use `%gometa -f` instead of introducing additional packages into i686 (I know this one is noarch only, but it introduces the possibility of dependent i686 packages in the future). On import, don't forget to do the following: - [ ] Add package to https://release-monitoring.org - [ ] Add package to https://koschei.fedoraproject.org/packages - [ ] Grant @go-sig group commit privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2216561 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202216561%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue