[Bug 2211754] Review Request: pkcs11-provider - A PKCS#11 provider for OpenSSL 3.0+

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2211754



--- Comment #7 from Jakub Jelen <jjelen@xxxxxxxxxx> ---
Seems like the fedora review service is broken. The above link gives me 404.
Locally fedora review fails too so I ran it against Fedora 38 chroot
temporarily, but it should give us some idea. Results:

Issues:
=======
- Sources used to build the package match the upstream source, as provided
  in the spec URL.

sounds like you put into srpm some unreleased version. I guess we will need an
upstream release with the changes first to get through the clean review but to
finalize the release, I think we can waive this.

[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/ossl-modules

this is now owned by openssl-libs but as mentioned below, we somehow lost the
dependency in the resulting package. This needs to be fixed.


There is dozens of issues like this reported by rpmlint which was not here last
time (Maybe related to https://github.com/latchset/pkcs11-provider/pull/251 ?):

pkcs11-provider.x86_64: W: undefined-non-weak-symbol
/usr/lib64/ossl-modules/pkcs11.so
ASN1_INTEGER_it»·(/usr/lib64/ossl-modules/pkcs11.so)    

Requires
--------
pkcs11-provider (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    rtld(GNU_HASH)

The openssl-libs needs to be here.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2211754

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202211754%23c7
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux