https://bugzilla.redhat.com/show_bug.cgi?id=2218306 Roman Inflianskas <rominf@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(code@musicinmybra | |in.net) Assignee|nobody@xxxxxxxxxxxxxxxxx |rominf@xxxxxxxx --- Comment #3 from Roman Inflianskas <rominf@xxxxxxxx> --- @code@xxxxxxxxxxxxxxxxxx I checked the spec file. It looks good. However: 1. I couldn't check it with `fedora-review` (see: https://bugzilla.redhat.com/show_bug.cgi?id=2217496). Review template link in the automatic message above is broken (probably, because of the same reason). 2. I believe I miss some knowledge (and I couldn't acquire it by searching on web). Could you please explain, why did you use variable `${ignore-} instead of defining a macro? Also, AFAIK, some shells do not allow `-` in variable names; how does this work and why does this mean? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2218306 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218306%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
