https://bugzilla.redhat.com/show_bug.cgi?id=2217967 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 address are Ok. TODO: Consider using <https://cpan.metacpan.org/authors/id/M/MA/MAXMIND/Devel-StackTrace-Extract-1.000000.tar.gz> for Source0. It's the canonical path listed on the home page. Source0 archive (SHA-512: 4e90aeafc410c69680b062206cf42010cd2f5182c54c9c830adf61058798cf9b7fb0e5c6fe47e08d3dc8750318600dc803a7d975bba764a4b29fb6ae0f924953) is original. Ok. Summary verified from lib/Devel/StackTrace/Extract.pm. Ok. Description verified from lib/Devel/StackTrace/Extract.pm. Ok. License verified from README.md, Makefile.PL, LICENSE, and lib/Devel/StackTrace/Extract.pm. Ok. No XS code, noarch BuildArch is Ok. FIX: Replace 'perl >= 0:5.006' build-dependency with 'perl(VERSION) >= 5.6' to declare a minimal version of Perl language and with 'perl-interpreter' to declare a dependency on a perl executable. 'perl' itself is unnecessarily large as it includes all core modules, header files, C compiler etc. '>= 0:5.006' is wrong because the epoch number does not align with Fedora history. TODO: Consider build-requiring all exception classes which t/extract.t exhibits and Fedora contains (e.g. Moose::Exception). Otherwise, that test tests nothing and is susceptible to random failures when any of the modules appears in a buildroot. TODO: Consider replacing '%{__perl}' macro with a plain 'perl' command. There is no benefit in hiding it behind a macro. TODO: Consider passing NOPACKLIST=1 and NOPERLLOCAL=1 arguments to Makefile.PL. Then you will have to build-require 'perl(ExtUtils::MakeMaker) >= 6.76', but you will be able to place "make pure_install..." with '%{make_install}' macro and remove both find commands. See <https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMaker>. TODO: Do not use top-level globs in %files section <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists>. All tests pass. Ok. $ rpmlint perl-Devel-StackTrace-Extract.spec ../SRPMS/perl-Devel-StackTrace-Extract-1.000000-1.fc39.src.rpm ../RPMS/noarch/perl-Devel-StackTrace-Extract-1.000000-1.fc39.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 ========= 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s ======== rpmlint is Ok. $ rpm -qlvp ../RPMS/noarch/perl-Devel-StackTrace-Extract-1.000000-1.fc39.noarch.rpm drwxr-xr-x 2 root root 0 Jun 27 02:00 /usr/share/doc/perl-Devel-StackTrace-Extract -rw-r--r-- 1 root root 90 Mar 30 2016 /usr/share/doc/perl-Devel-StackTrace-Extract/Changes -rw-r--r-- 1 root root 2987 Mar 30 2016 /usr/share/doc/perl-Devel-StackTrace-Extract/README.md drwxr-xr-x 2 root root 0 Jun 27 02:00 /usr/share/licenses/perl-Devel-StackTrace-Extract -rw-r--r-- 1 root root 18349 Mar 30 2016 /usr/share/licenses/perl-Devel-StackTrace-Extract/LICENSE -rw-r--r-- 1 root root 1989 Jun 27 02:00 /usr/share/man/man3/Devel::StackTrace::Extract.3pm.gz drwxr-xr-x 2 root root 0 Jun 27 02:00 /usr/share/perl5/vendor_perl/Devel drwxr-xr-x 2 root root 0 Jun 27 02:00 /usr/share/perl5/vendor_perl/Devel/StackTrace -rw-r--r-- 1 root root 5168 Mar 30 2016 /usr/share/perl5/vendor_perl/Devel/StackTrace/Extract.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Devel-StackTrace-Extract-1.000000-1.fc39.noarch.rpm | sort -f | uniq -c 1 perl(base) 1 perl(Devel::StackTrace) 1 perl(Devel::StackTrace::Frame) 1 perl(Exporter) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Devel-StackTrace-Extract-1.000000-1.fc39.noarch.rpm | sort -f | uniq -c 1 perl(Devel::StackTrace::Extract) = 1.000000 1 perl-Devel-StackTrace-Extract = 1.000000-1.fc39 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Devel-StackTrace-Extract-1.000000-1.fc39.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=102700234). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX item, consider fixing TODO items, and provide a new spec file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2217967 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202217967%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
