https://bugzilla.redhat.com/show_bug.cgi?id=2214384 --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to blinxen from comment #2) > Taking this review Thanks for taking a look! > General comments: > > - Package was generated with rust2rpm and some changes were made > - Tests were deactivated because of a missing dependency --> should be OK > but packaging dependency and reactivating tests is preffered In this case, I'd really rather not. Packaging pre-releases is painful. > Issues: > > - Feature `__test_helpers` is packaged with the crate. I don't think this > should be packaged. The feature is only meant to be used internally by the > crate (from my understanding). Good catch, I will update the spec to remove this feature subpackage. > - The code itself is licensed under MIT but the author wrote "A lot of the > code in this package was based on Julien Schmidt's httprouter." and included > the license file (BSD-3-Clause) of `httprouter` in the crate. Shouldn't the > package also have both licenses defined (MIT and BSD-3-Clause)? Not sure how to handle this. The "httprouter" project is written entirely in Go ... So this crate would need to be a 100% rewrite since it can't even contain any of the original code, and I don't think licenses carry over for 100% rewrites. I've uploaded updated files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2214384 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202214384%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
