https://bugzilla.redhat.com/show_bug.cgi?id=2217729 --- Comment #4 from Richard W.M. Jones <rjones@xxxxxxxxxx> --- Interestingly libyaml & the copy of libyaml in ocaml-yaml are identical, which I did not expect: 6e605fc9634e93e0187069a2e871d16d /home/rjones/d/libyaml/src/api.c 6e605fc9634e93e0187069a2e871d16d /home/rjones/d/ocaml-yaml/vendor/api.c 948f2ac1f42b36f9b6ed10ce0291bdb9 /home/rjones/d/libyaml/src/dumper.c 948f2ac1f42b36f9b6ed10ce0291bdb9 /home/rjones/d/ocaml-yaml/vendor/dumper.c 3867fc7a11ee386b8a5106cb506cb9c0 /home/rjones/d/libyaml/src/emitter.c 3867fc7a11ee386b8a5106cb506cb9c0 /home/rjones/d/ocaml-yaml/vendor/emitter.c d1bb577f92e25d50b313da8d022f3149 /home/rjones/d/libyaml/src/loader.c d1bb577f92e25d50b313da8d022f3149 /home/rjones/d/ocaml-yaml/vendor/loader.c 9c4f0181665c37d4bcdd05535e6a2130 /home/rjones/d/libyaml/src/parser.c 9c4f0181665c37d4bcdd05535e6a2130 /home/rjones/d/ocaml-yaml/vendor/parser.c efcea8b4a8bcfbc96ae32abd0f18e472 /home/rjones/d/libyaml/src/reader.c efcea8b4a8bcfbc96ae32abd0f18e472 /home/rjones/d/ocaml-yaml/vendor/reader.c 830f57f176e768c7fa97d086de18050d /home/rjones/d/libyaml/src/scanner.c 830f57f176e768c7fa97d086de18050d /home/rjones/d/ocaml-yaml/vendor/scanner.c 7b2e815cfd48dbfd462f3bd317059e3f /home/rjones/d/libyaml/src/writer.c 7b2e815cfd48dbfd462f3bd317059e3f /home/rjones/d/ocaml-yaml/vendor/writer.c f9a3252c2bb3f882698c10254b484541 /home/rjones/d/libyaml/src/yaml_private.h f9a3252c2bb3f882698c10254b484541 /home/rjones/d/ocaml-yaml/vendor/yaml_private.h but the header is different: 11d060175ea0cbb1fb94f2459f1bd6e3 /home/rjones/d/libyaml/include/yaml.h 8e57b936e51a0ac6eefdebdb6483ffde /home/rjones/d/ocaml-yaml/vendor/yaml.h Basically all the anonymous structs and unions in the header have been named. There are lots of changes like: yaml_token_type_t type; /** The token data. */ - union { + union data_u { /** The stream start (for @c YAML_STREAM_START_TOKEN). */ - struct { + struct stream_start_s { /** The stream encoding. */ yaml_encoding_t encoding; } stream_start; The README explains: > yaml.h has been modified to remove anonymous structs and unions, since ocaml-ctypes stub > generation needs to probe their sizes at compile-time. although it's not clear how adding names to structs achieves this. But let's assume it's necessary for ctypes. A possible way to unbundle this [ideally upstream] would be to copy /usr/include/yaml.h, apply some sed magic over it to add those names, then simply link to -lyaml for the code. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2217729 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202217729%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
