Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-kerberos - A high-level wrapper for Kerberos (GSSAPI) operations https://bugzilla.redhat.com/show_bug.cgi?id=427300 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-01-04 00:33 EST ------- There's no need that I can see this package to follow "Providing Eggs for non-setuptools packages" If anyone want this package to provide egg-info then file a bug once this gets in Fedora. Review: Review: + package builds in mock (development i386). + rpmlint is silent for RPM But not for SRPM python-kerberos.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 19) ==> its cosmetic message. You can fix that using sed. + source files match upstream. e9bc790e51187f3afa13dc2611e5d93a python-kerberos-1.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Compiler flags are honored correctly. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Package python-kerberos-1.0-2.fc9 -> Provides: kerberos.so Requires: python(abi) = 2.5 + Not a GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review