https://bugzilla.redhat.com/show_bug.cgi?id=2217167 --- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Mads Kiilerich from comment #6) > (In reply to Fabio Valentini from comment #5) > > Thaks for clarifying. > > > It looks like you've opted for option 3 (i.e. remove the "+web-devel" > > subpackage from the spec file, but not patch Cargo.toml. This is more or > > less equivalent to using the "unwanted-features" setting and *might or might > > not do what you expect depending on the circumstances*. I recommend patching > > out the "web" feature from Cargo.toml with "rust2rpm -p". > > No - I patch Cargo.toml too. I am editing whoami-fix-metadata-auto.diff . I > guess that can be confusing if expecting that one to be owned by rust2rpm. > But having multiple levels of patches is also confusing. That is indeed the *most* confusing option I've encountered yet ... Especially because the filename contains "auto" and the comment in the spec file says "Automatically generated" ... The "rust2rpm -p" workflow is intended to address this exact issue (even if it results in two levels of patch, one automatically generated that shouldn't be touched, one for manual changes). > > Thanks, the package looks good otherwise, I'll do the full review once the > > issue of the missing license texts is resolved. > > I fixed the license file issue upstream in 1.4.1, so it should be ready for > review: > > Spec URL: https://kiilerix.fedorapeople.org/rust-whoami.spec > SRPM URL: > https://kojipkgs.fedoraproject.org/work/tasks/6265/102616265/rust-whoami-1.4. > 1-1.fc39.src.rpm Thanks, I'll review after I had lunch. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2217167 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202217167%23c7 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
