https://bugzilla.redhat.com/show_bug.cgi?id=2217257 --- Comment #9 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #6) > The tests do not run. May want to do something like: > > cmake -S . > make > make test > > or using the macros > %cmake > %cmake_build > %ctest > > The CMakeLists file creates a virtual env and then uses that > to run the test: > https://github.com/nih-at/nihtest/blob/main/CMakeLists.txt#L29-L30 > > This does not work in the build system. Is there a good way to > use nihtest in %{buildroot}%{_bindir}/nihtest ? It took me a while to understand what you meant and to understand how the tests actually work. I'm not a CMake expert. Not using it often. Anyway, I tried locally using the macros and it indeed fails trying to install dependencies using pip. What I fail to deduct is what dependencies it is trying to install. If I can determine that, I could probably add these a BRs and modify the CMakeLists.txt, so it doesn't run pip. Otherwise, reverting to only running %pyproject_check_import may be the only option. (In reply to Remi Collet from comment #7) > Side note (please ignore it, probably no value) That's hard... ;) > I will probably never understand python Guidelines > I may understand the python3-xxx for a library, as this allows also to have > some python3.10-xxx and python3.12-xxx (parallel installable) > But this project is "nihtest", and provides the "nihtest" command and man > pages which will make parallel installation impossible > IMHO, for an application, the python namespace doesn't make any sense. Well, I had similar discussions regarding package names before. It boils down to what the main purpose of the package is. Is it primarily an application or commandline tool or is it primarily a library to be used by other packages. If in doubt or if it really is both, there's an option to add a Provides for the binary, so it's easier to find. I did that for another Python package: https://src.fedoraproject.org/rpms/python-fvs/blob/rawhide/f/python-fvs.spec#_37 Since we are still in review, I'd be happy to add that to the spec, so that 'dnf install nihtest' will work by pulling in python3-nihtest. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2217257 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202217257%23c9 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
