https://bugzilla.redhat.com/show_bug.cgi?id=2216299 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value CC| |decathorpe@xxxxxxxxx --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- I read the reason for disabling the tests - it would be relatively straightforward to add back the path-based dependency on gix-testtools as a normal version-based dependency (an example where I do this for an existing crate is rust-futures: https://src.fedoraproject.org/rpms/rust-futures/blob/rawhide/f/futures-fix-metadata.diff ). However, it looks like most of the tests are indeed excluded from published crates (probably they are in a separate "tests/" directory?), so I agree that just disabling tests is the more rational choice here. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (tests are disabled, reason documented) ! latest version of the crate is packaged (v0.22.0 was released) - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines === Package will be APPROVED if you say that bumping to v0.22.0 would cause additional work for other pending reviews. In that case, importing v0.21 now and updating to v0.22 later is fine with me. Otherwise, please update to the latest version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2216299 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202216299%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
