https://bugzilla.redhat.com/show_bug.cgi?id=2215629 --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Looks very good, a few tweaks should do it: - When using a manual release field, it should be greater than equal to 1: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_release_and_post_release_versions - one could use pyproject_save_files, but I think perhaps excluding the `test` directory there isn't currently doable (I couldn't see a way in the docs) [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. ^ The github repo does include the LICENSE file, so better to use that? [x]: Changelog in prescribed format. ^ One can use rpmautospec now to not need a changelog in the spec: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ rpmlint warnings: python3-pyembroidery.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-pyembroidery/README.md ^ This can be corrected: https://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding python3-pyembroidery.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/pyembroidery/PcsReader.py /usr/lib/python3.11/site-packages/pyembroidery/PcdReader.py:/usr/lib/python3.11/site-packages/pyembroidery/PcqReader.py ^ This is OK 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.1 s ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. ^ The github repo does include the LICENSE, so you could use that instead of the pypi source [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* MIT License", "Unknown or generated". 114 files have unknown license. Detailed output of licensecheck in /home/asinha/dump/fedora-reviews/2215629-python- pyembroidery/licensecheck.txt ^ SPDX: MIT, so this is correct [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. ^ One can use rpmautospec now: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [!]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ^ Please see the few messages (duplicate files are fine) [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. ^ The github sources do include the LICENSE file, so better to use those here. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. ^ tests pass [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pyembroidery-1.4.36-0.fc39.noarch.rpm python-pyembroidery-1.4.36-0.fc39.src.rpm =========================================================================== rpmlint session starts ========================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmprzh5pl8i')] checks: 31, packages: 2 python3-pyembroidery.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-pyembroidery/README.md python3-pyembroidery.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/pyembroidery/PcsReader.py /usr/lib/python3.11/site-packages/pyembroidery/PcdReader.py:/usr/lib/python3.11/site-packages/pyembroidery/PcqReader.py ============================================ 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.6 s =========================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 python3-pyembroidery.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-pyembroidery/README.md python3-pyembroidery.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/pyembroidery/PcsReader.py /usr/lib/python3.11/site-packages/pyembroidery/PcdReader.py:/usr/lib/python3.11/site-packages/pyembroidery/PcqReader.py 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.1 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/pyembroidery/pyembroidery-1.4.36.tar.gz : CHECKSUM(SHA256) this package : 1a4128c667618de85df840ab70913bbd5bd1967be4eaa6ac3b7367086941fd54 CHECKSUM(SHA256) upstream package : 1a4128c667618de85df840ab70913bbd5bd1967be4eaa6ac3b7367086941fd54 Requires -------- python3-pyembroidery (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-pyembroidery: python-pyembroidery python3-pyembroidery python3.11-pyembroidery python3.11dist(pyembroidery) python3dist(pyembroidery) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2215629 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: C/C++, fonts, Ocaml, R, Haskell, PHP, Perl, SugarActivity, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2215629 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202215629%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
