https://bugzilla.redhat.com/show_bug.cgi?id=2211754 --- Comment #1 from Jakub Jelen <jjelen@xxxxxxxxxx> --- Fedora review: Issues: ======= - Dist tag is present. (afaik the dist tag should be in the format of %{?dist} -- not sure how it got into the upstream without the question mark [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. (this is reported upstream as there are no signatures yet -- https://github.com/latchset/pkcs11-provider/issues/248) Rpmlint shows the following warnings: pkcs11-provider.spec: W: invalid-url Source0: pkcs11-provider-0.1.tar.gz (should probably point to the download location in github) (we should also probably use the tar.xz tarball instead of the github generated tar.gz) pkcs11-provider.x86_64: W: unused-direct-shlib-dependency /usr/lib64/ossl-modules/pkcs11.so /lib64/libssl.so.3 (i think we do not need libssl here, but would have to check) pkcs11-provider.x86_64: W: dangling-relative-symlink /usr/share/doc/pkcs11-provider/README README.md (this looks like an upstream issue as we install README, which is just a symlink to README.md, but README.md is not installed -- this needs to be fixed as part of the build process I think) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2211754 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202211754%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
