https://bugzilla.redhat.com/show_bug.cgi?id=2215187 --- Comment #3 from Felix Wang <topazus@xxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 2.1", "*No copyright* Apache License 2.0", "Apache License 2.0", "FSF All Permissive License", "GNU General Public License v2.0 or later", "GNU General Public License v3.0 or later", "GNU Lesser General Public License GNU General Public License, Version 2". 156 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/gensio/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/libexec/gensio/2.6.6 [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/libexec/gensio/2.6.6 [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 225280 bytes in 20 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libgensio , libgensio-ipmisol , libgensio-mdns , libgensio-sound , libgensio-tcl , python3-gensio [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: gensio-2.6.6-1.fc39.x86_64.rpm libgensio-2.6.6-1.fc39.x86_64.rpm libgensio-devel-2.6.6-1.fc39.x86_64.rpm libgensio-ipmisol-2.6.6-1.fc39.x86_64.rpm libgensio-mdns-2.6.6-1.fc39.x86_64.rpm libgensio-sound-2.6.6-1.fc39.x86_64.rpm libgensio-tcl-2.6.6-1.fc39.x86_64.rpm python3-gensio-2.6.6-1.fc39.x86_64.rpm gensio-debuginfo-2.6.6-1.fc39.x86_64.rpm gensio-debugsource-2.6.6-1.fc39.x86_64.rpm gensio-2.6.6-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpzimvcalw')] checks: 31, packages: 11 gensio.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/gtlsshd 11 packages and 0 specfiles checked; 1 errors, 0 warnings, 1 badness; has taken 2.7 s Rpmlint (debuginfo) ------------------- Checking: gensio-debuginfo-2.6.6-1.fc39.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp4buta658')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 10 gensio.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/gtlsshd 10 packages and 0 specfiles checked; 1 errors, 0 warnings, 1 badness; has taken 3.8 s Unversioned so-files -------------------- libgensio: /usr/libexec/gensio/2.6.6/libgensio_afskmdm.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_ax25.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_certauth.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_cm108gpio.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_conacc.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_dummy.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_echo.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_file.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_keepopen.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_kiss.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_msgdelim.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_mux.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_net.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_perf.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_pty.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_ratelimit.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_relpkt.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_script.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_serialdev.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_ssl.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_stdio.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_telnet.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_trace.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_udp.so libgensio: /usr/libexec/gensio/2.6.6/libgensio_xlt.so libgensio-ipmisol: /usr/libexec/gensio/2.6.6/libgensio_ipmisol.so libgensio-mdns: /usr/libexec/gensio/2.6.6/libgensio_mdns.so libgensio-sound: /usr/libexec/gensio/2.6.6/libgensio_sound.so python3-gensio: /usr/lib64/python3.11/site-packages/_gensio.so python3-gensio: /usr/lib64/python3.11/site-packages/_gensioglib.so python3-gensio: /usr/lib64/python3.11/site-packages/_gensiotcl.so python3-gensio: /usr/lib64/python3.11/site-packages/_pygensio.so python3-gensio: /usr/lib64/python3.11/site-packages/_pygensioglib.so python3-gensio: /usr/lib64/python3.11/site-packages/_pygensiotcl.so Source checksums ---------------- https://github.com/cminyard/gensio/archive/v2.6.6/gensio-2.6.6.tar.gz : CHECKSUM(SHA256) this package : b94379310112d2506b5eaa06e4af8aeffe4f2d7430b08876d2e1733b742ea84a CHECKSUM(SHA256) upstream package : b94379310112d2506b5eaa06e4af8aeffe4f2d7430b08876d2e1733b742ea84a Requires -------- gensio (rpmlib, GLIBC filtered): /usr/bin/python3 /usr/bin/sh libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgensio.so.4()(64bit) libgensioglib.so.4()(64bit) libgensiomdns.so.4()(64bit) libgensioosh.so.4()(64bit) libgensiotcl.so.4()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) rtld(GNU_HASH) libgensio (rpmlib, GLIBC filtered): glibc libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgensio.so.4()(64bit) libgensioosh.so.4()(64bit) libgensiooshcpp.so.4()(64bit) libglib-2.0.so.0()(64bit) libm.so.6()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) rtld(GNU_HASH) libgensio-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libgensio(x86-64) libgensio.so.4()(64bit) libgensio_python_swig.so.4()(64bit) libgensiocpp.so.4()(64bit) libgensioglib.so.4()(64bit) libgensiomdns.so.4()(64bit) libgensiomdnscpp.so.4()(64bit) libgensioosh.so.4()(64bit) libgensiooshcpp.so.4()(64bit) libgensiotcl.so.4()(64bit) libgensio-ipmisol (rpmlib, GLIBC filtered): libOpenIPMI.so.0()(64bit) libOpenIPMIutils.so.0()(64bit) libc.so.6()(64bit) libgensio.so.4()(64bit) libgensioosh.so.4()(64bit) rtld(GNU_HASH) libgensio-mdns (rpmlib, GLIBC filtered): libavahi-client.so.3()(64bit) libavahi-common.so.3()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgensio.so.4()(64bit) libgensiomdns.so.4()(64bit) libgensioosh.so.4()(64bit) libgensiooshcpp.so.4()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) libgensio-sound (rpmlib, GLIBC filtered): libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libc.so.6()(64bit) libgensio.so.4()(64bit) libgensioosh.so.4()(64bit) rtld(GNU_HASH) libgensio-tcl (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgensioosh.so.4()(64bit) libtcl8.6.so()(64bit) rtld(GNU_HASH) python3-gensio (rpmlib, GLIBC filtered): glibc ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgensio.so.4()(64bit) libgensio_python_swig.so.4()(64bit) libgensiocpp.so.4()(64bit) libgensioglib.so.4()(64bit) libgensiomdns.so.4()(64bit) libgensiomdnscpp.so.4()(64bit) libgensioosh.so.4()(64bit) libgensiooshcpp.so.4()(64bit) libgensiotcl.so.4()(64bit) libpython3.11.so.1.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) python(abi) rtld(GNU_HASH) gensio-debuginfo (rpmlib, GLIBC filtered): gensio-debugsource (rpmlib, GLIBC filtered): Provides -------- gensio: gensio gensio(x86-64) libgensio: libgensio libgensio(x86-64) libgensio.so.4()(64bit) libgensio_afskmdm.so()(64bit) libgensio_ax25.so()(64bit) libgensio_certauth.so()(64bit) libgensio_cm108gpio.so()(64bit) libgensio_conacc.so()(64bit) libgensio_dummy.so()(64bit) libgensio_echo.so()(64bit) libgensio_file.so()(64bit) libgensio_keepopen.so()(64bit) libgensio_kiss.so()(64bit) libgensio_msgdelim.so()(64bit) libgensio_mux.so()(64bit) libgensio_net.so()(64bit) libgensio_perf.so()(64bit) libgensio_pty.so()(64bit) libgensio_ratelimit.so()(64bit) libgensio_relpkt.so()(64bit) libgensio_script.so()(64bit) libgensio_serialdev.so()(64bit) libgensio_ssl.so()(64bit) libgensio_stdio.so()(64bit) libgensio_telnet.so()(64bit) libgensio_trace.so()(64bit) libgensio_udp.so()(64bit) libgensio_xlt.so()(64bit) libgensiocpp.so.4()(64bit) libgensioglib.so.4()(64bit) libgensioosh.so.4()(64bit) libgensiooshcpp.so.4()(64bit) libgensio-devel: libgensio-devel libgensio-devel(x86-64) pkgconfig(libgensio) pkgconfig(libgensio_python_swig) pkgconfig(libgensiocpp) pkgconfig(libgensioglib) pkgconfig(libgensiomdns) pkgconfig(libgensiomdnscpp) pkgconfig(libgensioosh) pkgconfig(libgensiooshcpp) pkgconfig(libgensiotcl) libgensio-ipmisol: libgensio-ipmisol libgensio-ipmisol(x86-64) libgensio_ipmisol.so()(64bit) libgensio-mdns: libgensio-mdns libgensio-mdns(x86-64) libgensio_mdns.so()(64bit) libgensiomdns.so.4()(64bit) libgensiomdnscpp.so.4()(64bit) libgensio-sound: libgensio-sound libgensio-sound(x86-64) libgensio_sound.so()(64bit) libgensio-tcl: libgensio-tcl libgensio-tcl(x86-64) libgensiotcl.so.4()(64bit) python3-gensio: libgensio_python_swig.so.4()(64bit) python-gensio python3-gensio python3-gensio(x86-64) python3.11-gensio gensio-debuginfo: debuginfo(build-id) gensio-debuginfo gensio-debuginfo(x86-64) gensio-debugsource: gensio-debugsource gensio-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name gensio --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, C/C++, Generic Disabled plugins: PHP, fonts, Ocaml, Java, Perl, Haskell, SugarActivity, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH --- Some issues which appeared in the review.txt and you gave notes to clearly explain them. A few minor issues are needed to fixed. 1) > [ ]: Package requires other packages for directories it uses. > Note: No known owner of /usr/libexec/gensio/2.6.6 > [ ]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/libexec/gensio/2.6.6 Add `%dir %{_libexecdir}/gensio/2.6.6` to own the directory. 2) > License: GPL-2.0-only and LGPL-2.1-only and Apache-2.0 The license should be `GPL-2.0-only AND LGPL-2.1-only AND Apache-2.0` The remain parts look good from my perspective. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2215187 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202215187%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
