Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: drpython - a python IDE channel https://bugzilla.redhat.com/show_bug.cgi?id=427218 ------- Additional Comments From maxx@xxxxxxxxx 2008-01-03 16:13 EST ------- builds cleanly in mock (fedora-8-i386) rpmlint output: drpython.noarch: W: file-not-utf8 /usr/share/doc/drpython-165/History.txt drpython.noarch: W: file-not-utf8 /usr/share/doc/drpython-165/Changelog.txt drpython.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 11) The utf-8 issues need not be fixed - but please fix the mixed spaces and tabs in the .spec file. The Icon entry in the .desktop should be without the file extension (ie. drpython instead of drpython.png). It might be nice to include a small shell script called drpython which could be installed in /usr/bin to start drpython. The icon drpython.png must be installed to /usr/share/pixmaps to be found by the .desktop file. So all in all it looks quite good. The issues that must be fixed are: 1) the mixed use of tabs and spaces in the .spec file 2) the icon must be installed so that it shows up in the menus And of course it would be nice if some of the other minor issues could be fixed as well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review