https://bugzilla.redhat.com/show_bug.cgi?id=2215174 Jeremy Newton <alexjnewt@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+ --- Comment #9 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> --- You could probably use: > %{_docdir}/%{name} > %{_datadir}/cmake/%{name} For consistency. I tested building rocsparse and it builds fine, but since it's a mix of C++ and Fortran, it made me realise that we should probably not muck around with global optflags, but rather just only change c++, like so: > %global build_cxxflags %(echo %{optflags} | sed -e 's/-fstack-protector-strong/-Xarch_host -fstack-protector-strong/' -e 's/-fcf-protection/-Xarch_host -fcf-protection/') It also simplifies the sed hackery. I'll been patching rocrand shortly with this. Anyway, not huge blockers. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2215174 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202215174%23c9 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
