[Bug 2215174] Review Request: rocprim ROCm parallel primative

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2215174



--- Comment #5 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> ---
> This is a noarch package, but I went with an exclusive arch because to be useful the rest of rocm needs to be supported on more than x86_64.  We would have unhappy ppc, arm and s390 folks that installed this package and got frustrated that nothing else worked.

Well you can set both exclusive arch AND noarch and it will work (they aren't
mutually exclusive). See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_noarch_with_unported_dependencies

But if you use noarch, I think you should only apply noarch to the devel
subpackage to tell koji to specifically build it on a x86_64 machine only. I'm
not 100% sure if this is correct.

E.g:

%package devel
BuildArch: noarch

But I'm also okay with keeping as-is if you think that's clearer/cleaner.

I kicked off a copr build, and will review it when it's done:
https://copr.fedorainfracloud.org/coprs/mystro256/rocm-hip/build/6087516/


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2215174

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202215174%23c5
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux