https://bugzilla.redhat.com/show_bug.cgi?id=2214834 --- Comment #3 from Chris Kelley <ckelley@xxxxxxxxxx> --- (In reply to Sandro Mani from comment #1) > Approved - the only potential issue I see is > > [!]: If package contains pom.xml files install it (including metadata) even > when building with ant > > The source zip contains a pom.xml. The guidelines [1] state "If upstream > project is shipping Maven pom.xml files, these MUST be installed." Please > verify before importing. > > [1] > https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/ > #_maven_pom_xml_files "mvn install"/"%mvn_install" installs the pom. My understanding of this requirement is that you need to make sure the pom is installed even if you are not using Maven (e.g. ant, cmake, whatever) so for this package I believe this is not applicable. Thanks for taking the time to review, much appreciated! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2214834 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202214834%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
