https://bugzilla.redhat.com/show_bug.cgi?id=2215078 Felix Wang <topazus@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |topazus@xxxxxxxxxxx --- Comment #1 from Felix Wang <topazus@xxxxxxxxxxx> --- Issues: ======= - Header files in -devel subpackage, if present. Note: libjodycode : /usr/include/libjodycode.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: libjodycode. Illegal package name: libjodycode. Does not provide -static: libjodycode. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries libjodycode.x86_64: E: static-library-without-debuginfo /usr/lib64/libjodycode.a libjodycode.x86_64: W: devel-file-in-non-devel-package /usr/include/libjodycode.h libjodycode.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libjodycode.a 5 packages and 0 specfiles checked; 1 errors, 2 warnings, 1 badness; has taken 0.3 s a) Is there any possibility of avoiding packaging the static library file? If really necessary, create a -static package to store the static lib. b) put the header file into -devel subpackage. c) > %forgesetup > %patch -P 0 -p1 the two lines could be replaced by ``` %forgeautosetup -p1 ``` d) > Patch0: libjodycode-2.0.1-Makefile.patch add comment above the patch line to explain. ref: https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/#_all_patches_should_have_an_upstream_bug_link_or_comment -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2215078 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202215078%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
