[Bug 2133551] Review Request: fido-device-onboard - A rust implementation of the FIDO Device Onboard Specification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2133551



--- Comment #36 from Peter Robinson <pbrobinson@xxxxxxxxx> ---
(In reply to Fabio Valentini from comment #34)
> RPM cannot parse the linked spec file - the %{gittag} macro is undefined
> (and it looks like it's no longer used).

It was cut and paste directly from the packaging guidelines you suggested in
comment 18, point 3. I will remove.

> Additionally, at first glance, "%global debug_package %{nil}" is a red flag.
> It should not be needed - but if it *is* needed to make RPM happy, then the
> package is built without debuginfo, i.e. with nonstandard compiler flags. I
> can't see any indication of custom cargo profiles, so likely "%global
> debug_package %{nil}" can just be removed to restore debuginfo subpackage
> generation.

Probabky a left over of the 100 revisions. Can't those just be fixed on commit?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2133551

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202133551%23c36
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux