https://bugzilla.redhat.com/show_bug.cgi?id=2209067 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > BuildRequires are ok > FIX: Add build-require > - coreutils - it is needed for %{_fixperms} > - perl(strict) - File-Inplace-0.20/lib/File/Inplace.pm:2 Ok. > FIX: Remove duplicate dependency 'perl(File::Copy)' Ok. > TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 > NO_PACKLIST is provided since this version. Ok. > > FIX: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} > directories > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists Ok. Resolution: Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2209067 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202209067%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue