https://bugzilla.redhat.com/show_bug.cgi?id=2213979 Tom Rix <trix@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Tom Rix <trix@xxxxxxxxxx> --- i am fine with just x86_64 for now some comments on the spec filefedora > diff -u rocrand.spec rocrand.spec.review --- rocrand.spec 2023-06-08 17:00:00.000000000 -0700 +++ rocrand.spec.review 2023-06-10 16:34:21.834345933 -0700 @@ -4,15 +4,19 @@ %global rocm_patch 1 %global rocm_version %{rocm_release}.%{rocm_patch} -%undefine _hardened_build +# Explain, commenting them out and still builds +# %undefine _hardened_build # Compiler is hipcc, which is clang based: %global toolchain clang #The target doesn't support -fcf-protection: -%global optflags %(o="%{optflags}"; echo ${o//-fcf-protection/}) +# %global optflags %(o="%{optflags}"; echo ${o//-fcf-protection/}) + +# Nice to have a check +%bcond_with check Name: rocrand Version: %{rocm_version} -Release: 1%{?dist} +Release: 2%{?dist} Summary: ROCm random number generator Url: https://github.com/ROCmSoftwarePlatform @@ -25,6 +29,10 @@ BuildRequires: cmake BuildRequires: compiler-rt BuildRequires: clang-devel +# rocrand-devel.x86_64: W: no-documentation +# hiprand-devel.x86_64: W: no-documentation +# no docs warnings, add build requires till you get some autogen-ed stuff +BuildRequires: doxygen BuildRequires: glibc-headers BuildRequires: lld BuildRequires: llvm-devel @@ -32,6 +40,9 @@ BuildRequires: rocm-comgr-devel BuildRequires: rocm-hip-devel BuildRequires: rocm-runtime-devel +%if %{with check} +# Add some stuff +%endif # Only x86_64 works right now: ExclusiveArch: x86_64 @@ -45,7 +56,9 @@ Radeon Open Compute ROCm runtime, but it also works on CUDA enabled GPUs. %package devel -Summary: rocRAND development package +# rocrand-devel.x86_64: W: summary-not-capitalized rocRAND development package +# Summary: rocRAND development package +Summary: The rocRAND development package Requires: %{name}%{?_isa} = %{version}-%{release} %description devel @@ -62,7 +75,8 @@ backend. Currently, hipRAND supports either rocRAND or cuRAND. %package -n hiprand-devel -Summary: hipRAND development package +#Summary: hipRAND development package +Summary: The hipRAND development package Requires: hiprand%{?_isa} = %{version}-%{release} %description -n hiprand-devel @@ -75,19 +89,34 @@ mv hipRAND-rocm-%{version}/* hipRAND/ %build -export CXX=hipcc +# use cmake option over export +# export CXX=hipcc +# Reordered the options in alpha order %cmake \ - -DROCM_SYMLINK_LIBS=OFF \ - -DCMAKE_INSTALL_LIBDIR=%{_lib} \ - -DBUILD_FILE_REORG_BACKWARD_COMPATIBILITY=OFF + -DBUILD_FILE_REORG_BACKWARD_COMPATIBILITY=OFF \ +%if %{with check} + -DBUILD_TEST=ON \ +%endif + -DCMAKE_INSTALL_LIBDIR=%{_lib} \ + -DCMAKE_CXX_COMPILER=hipcc \ + -DROCM_SYMLINK_LIBS=OFF + %cmake_build +# takes a long time and needs a gpu.. +%if %{with check} +%ctest +%endif + + %install %cmake_install +# why ? chrpath --delete %{buildroot}/%{_libdir}/libhiprand.so.1.* %files -%doc CHANGELOG.md +# Use readme over changelog +%doc README.md %license LICENSE.txt %{_libdir}/lib%{name}.so.1{,.*} %exclude %{_docdir}/%{name}/LICENSE.txt @@ -98,7 +127,7 @@ %{_libdir}/cmake/%{name} %files -n hiprand -%doc hipRAND/CHANGELOG.md +%doc hipRAND/README.md %license hipRAND/LICENSE.txt %{_libdir}/libhiprand.so.1{,.*} @@ -108,5 +137,8 @@ %{_libdir}/cmake/hiprand %changelog +* Sat Jun 10 2023 Tom Rix <trix@xxxxxxxxxx> - 5.5.1-2 +- Review + * Fri Jun 09 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 5.5.1-1 - Initial package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2213979 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202213979%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
