Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-xlrd - Library to extract data from Microsoft Excel (tm) spreadsheet files https://bugzilla.redhat.com/show_bug.cgi?id=243955 ------- Additional Comments From lkundrak@xxxxxxxxxx 2008-01-03 09:05 EST ------- 1.) 38 # add shebang and remove .py file 39 ( 40 echo '#!/usr/bin/env python' 41 cat $RPM_BUILD_ROOT/usr/bin/runxlrd.py 42 ) >> $RPM_BUILD_ROOT/usr/bin/runxlrd 43 rm -rf $RPM_BUILD_ROOT/usr/bin/runxlrd.py* \ Please replace "/usr/bin" with %{_bindir} (and eventually with "/usr/bin/env python" with %{__python} in case you consider %{__python} macro to be acceptably usable in specs -- ans you seem to do) 2.) 58 %attr(755,root,root) /usr/bin/* Likewise 3.) The package should contain the text of the license -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review