https://bugzilla.redhat.com/show_bug.cgi?id=2213779 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > %autosetup -n %{name}-%{version} -p1 The "-n %{name}-%{version}" is superfluous and can be dropped. > %{cmake_kf5} You can drop the curly braces here. > %{_libdir}/libkjournald.so > %{_libdir}/libkjournald.so.23 > %{_libdir}/libkjournald.so.23.04.2 This needs to be broken out to a -libs subpackage. The library seems to be versioned by the software version, so you'll want macros to track that. For example, add the following to the top of the spec: %global majorver 23 %global fullver %{majorver}.04.2 Then change the Version as follows: Version: %{fullver} Then change the file list as follows: %{_libdir}/libkjournald.so %{_libdir}/libkjournald.so.%{majorver} %{_libdir}/libkjournald.so.%{fullver} -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2213779 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202213779%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
