https://bugzilla.redhat.com/show_bug.cgi?id=2213169 --- Comment #6 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Issues: remove_hatch-nodejs-version.patch has no comment in the specfile and no commit message either. In order to understand why it is needed, I must have read the diff and made assumptions. See https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/#_all_patches_should_have_an_upstream_bug_link_or_comment python-jupyter-collaboration.spec:17: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 17) (The tab is just trailing and should be removed.) python3-jupyter-collaboration.noarch: E: backup-file-in-package /usr/share/jupyter/labextensions/@jupyter/collaboration-extension/schemas/@jupyter/collaboration-extension/package.json.orig (I don't say this is a blocker but might be a good idea to fix that upsream?) License: BSD-3-Clause -> BSD-3-Clause AND MIT: jupyter_collaboration/labextension/static/third-party-licenses.json is MIT packages/collaboration/src/cursors.ts is BSD 3-Clause AND MIT /usr/share/jupyter/labextensions/@jupyter/collaboration-extension/static/third-party-licenses.json also mentions a couple bundled libraries (not provided from the spec) licensed as MIT -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2213169 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202213169%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
