https://bugzilla.redhat.com/show_bug.cgi?id=2167789 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Flags| |fedora-review+ CC| |benson_muite@xxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |benson_muite@xxxxxxxxxxxxx Status|NEW |POST --- Comment #2 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License". 16 files have unknown license. Detailed output of licensecheck in /home/fedora/php-reviews2/2167789-php-sebastian- object-reflector3/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/php/SebastianBergmann(php-sebastian-global-state2, php- sebastian-diff3, php-phpunit-FinderFacade, php-phpunit-php-text- template2, php-sebastian-lines-of-code, php-phpunit-php-timer2, php- sebastian-version3, php-sebastian-complexity, php-sebastian-diff4, php-sebastian-recursion-context, php-phpunit-diff, php-phpunit-php- token-stream2, php-sebastian-code-unit-reverse-lookup2, php-sebastian- environment4, php-sebastian-code-unit, php-sebastian-cli-parser, php- sebastian-global-state, php-sebastian-object-reflector, php-sebastian- type, php-sebastian-type3, php-phpunit-php-token-stream3, php-phpunit- php-invoker3, php-sebastian-recursion-context3, php-phpunit-php-file- iterator2, php-phpunit-php-token-stream4, php-phpunit-php-invoker2, php-sebastian-environment5, php-sebastian-resource-operations, php- phpunit-php-file-iterator3, php-sebastian-object-reflector2, php- sebastian-recursion-context4, php-sebastian-finder-facade2, php- phpunit-php-timer3, php-phpunit-environment, php-phpunit-git, php- phpunit-Version, php-sebastian-code-unit-reverse-lookup, php- sebastian-resource-operations2, php-phpunit-PHPUnit-SkeletonGenerator, php-sebastian-resource-operations3, php-phpunit-php-timer5) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. PHP: [x]: Run phpci static analyze on all php files. Note: 7.0.0@7b05300 static analyze results in /home/fedora/php- reviews2/2167789-php-sebastian-object-reflector3/phpci.log Rpmlint ------- Checking: php-sebastian-object-reflector3-3.0.0-1.fc39.noarch.rpm php-sebastian-object-reflector3-3.0.0-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpud6z7j6b')] checks: 31, packages: 2 php-sebastian-object-reflector3.spec: W: invalid-url Source0: php-sebastian-object-reflector3-3.0.0-24ed13d.tgz 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s Requires -------- php-sebastian-object-reflector3 (rpmlib, GLIBC filtered): php(language) php-composer(fedora/autoloader) php-spl Provides -------- php-sebastian-object-reflector3: php-composer(sebastian/object-reflector) php-sebastian-object-reflector3 Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2167789 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: SugarActivity, Python, C/C++, fonts, Perl, Haskell, Java, Ocaml, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH a) Builds on all architectures: https://copr.fedorainfracloud.org/coprs/fed500/phpunit10/build/6008349/ b) For Source0 instead of: %{name}-%{version}-%{gh_short}.tgz one can use a url with the commit/tag see https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ which would also mean that the makesrc.script is no longer needed for Fedora. Perhaps can be fixed on import? Would apply to other packages, but not a blocker. c) php-spl does not seem to be needed, compatinfo report is empty for me. Not a blocker, but please confirm it is needed before importing d) Tests require phpunit 10 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2167789 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202167789%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
