https://bugzilla.redhat.com/show_bug.cgi?id=2169357 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #15 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Thanks. > a: Done Thanks. > b: License.md is already marked by rpm-python-macro Ok, it is in usr/lib/python3.11/site-packages/stats_collect-1.0.3.dist-info/ > c: You asked me too add it before :) Sorry, review tool indicates preference for the license folder and not in share/javascript/stats-collect/js/dist/ Duplicate seems ok. Please add a license breakdown in the spec file indicating bundled library is also BSD. Can be done on import. > d: Yes we knew that just waiting for stats-collect's approval and then we'll release new version wult without those binaries. Ok. There seems to be some problem with installation: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169357-stats-collect/fedora-rawhide-x86_64/06006722-stats-collect/fedora-review/review.txt https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169357-stats-collect/fedora-rawhide-x86_64/06006722-stats-collect/builder-live.log.gz root.log contains: DEBUG util.py:444: package stats-collect is not installed DEBUG util.py:595: Child return code was: 1 and DEBUG util.py:442: Error: DEBUG util.py:442: Problem: conflicting requests DEBUG util.py:442: - nothing provides wult(x86-64) >= 1.11.21 needed by stats-collect-1.0.3-1.fc39.noarch from @commandline DEBUG util.py:444: (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages) DEBUG util.py:595: Child return code was: 1 DEBUG util.py:167: kill orphans So I guess will be fixed when Wult is simultaneously updated. Approved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2169357 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202169357%23c15 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue