https://bugzilla.redhat.com/show_bug.cgi?id=2179404 --- Comment #18 from Petr Pisar <ppisar@xxxxxxxxxx> --- FIX: Use "%{_prefix}" instead of "/usr" in "-DOpenVDB_ROOT=/usr" argument. FIX: Add "BSL-1.0" to License tag because of /usr/bin/vklTests packaged in openvkl binary package. /usr/bin/vklTests is built from testing/apps/vklTests.cpp which includes testing/external/catch.hpp which is BSL-1.0. FIX: Add "MIT" to License tag because /usr/bin/vklTests is built from tests/vectorized_sampling.cpp which includes testing/openvkl_testing.h which includes testing/volume/OpenVdbVolume.h which includes testing/external/half.hpp which is MIT. Don't forget to redefine a License tag for the devel subpackage so that it does not mention BSL-1.0 and MIT. All tests pass. Ok. $ rpmlint openvkl.spec ../SRPMS/openvkl-1.3.2-1.fc39.src.rpm ../RPMS/x86_64/openvkl-* ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 6 openvkl.x86_64: W: no-manual-page-for-binary vklTests openvkl-devel.x86_64: W: no-documentation ========= 5 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 1.7 s ======== rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/openvkl-1.3.2-1.fc39.x86_64.rpm -rwxr-xr-x 1 root root 2021672 Jun 5 02:00 /usr/bin/vklTests drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib/.build-id/34 lrwxrwxrwx 1 root root 41 Jun 5 02:00 /usr/lib/.build-id/34/3e0702221a970e32864340133d592df37015bd -> ../../../../usr/lib64/libopenvkl.so.1.3.2 drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib/.build-id/45 lrwxrwxrwx 1 root root 61 Jun 5 02:00 /usr/lib/.build-id/45/aceb3f3f8552403af8e6384bd898137a199cdb -> ../../../../usr/lib64/libopenvkl_module_cpu_device_4.so.1.3.2 drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib/.build-id/4c lrwxrwxrwx 1 root root 59 Jun 5 02:00 /usr/lib/.build-id/4c/bca0200125773eb33295e2aac821b59bdae9e2 -> ../../../../usr/lib64/libopenvkl_module_cpu_device.so.1.3.2 drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib/.build-id/80 lrwxrwxrwx 1 root root 28 Jun 5 02:00 /usr/lib/.build-id/80/f310f2ca98a52d254a825b5b4d1fa3edc8b344 -> ../../../../usr/bin/vklTests drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib/.build-id/83 lrwxrwxrwx 1 root root 61 Jun 5 02:00 /usr/lib/.build-id/83/69b939c2e4e7b99a2859b49cf9df38394cc622 -> ../../../../usr/lib64/libopenvkl_module_cpu_device_8.so.1.3.2 drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib/.build-id/8d lrwxrwxrwx 1 root root 62 Jun 5 02:00 /usr/lib/.build-id/8d/77a2677445857c3eb89ae9b32cf324c6abb400 -> ../../../../usr/lib64/libopenvkl_module_cpu_device_16.so.1.3.2 lrwxrwxrwx 1 root root 19 Jun 5 02:00 /usr/lib64/libopenvkl.so.1 -> libopenvkl.so.1.3.2 -rwxr-xr-x 1 root root 183168 Jun 5 02:00 /usr/lib64/libopenvkl.so.1.3.2 lrwxrwxrwx 1 root root 37 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device.so.1 -> libopenvkl_module_cpu_device.so.1.3.2 -rwxr-xr-x 1 root root 20632 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device.so.1.3.2 lrwxrwxrwx 1 root root 40 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_16.so.1 -> libopenvkl_module_cpu_device_16.so.1.3.2 -rwxr-xr-x 1 root root 8411648 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_16.so.1.3.2 lrwxrwxrwx 1 root root 39 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_4.so.1 -> libopenvkl_module_cpu_device_4.so.1.3.2 -rwxr-xr-x 1 root root 9549696 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_4.so.1.3.2 lrwxrwxrwx 1 root root 39 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_8.so.1 -> libopenvkl_module_cpu_device_8.so.1.3.2 -rwxr-xr-x 1 root root 10078496 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_8.so.1.3.2 drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/share/doc/openvkl -rw-r--r-- 1 root root 15168 Feb 28 19:14 /usr/share/doc/openvkl/CHANGELOG.md -rw-r--r-- 1 root root 131049 Feb 28 19:14 /usr/share/doc/openvkl/README.md -rw-r--r-- 1 root root 520 Feb 28 19:14 /usr/share/doc/openvkl/SECURITY.md drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/share/licenses/openvkl -rw-r--r-- 1 root root 11358 Feb 28 19:14 /usr/share/licenses/openvkl/LICENSE.txt -rw-r--r-- 1 root root 20741 Feb 28 19:14 /usr/share/licenses/openvkl/third-party-programs-Embree.txt -rw-r--r-- 1 root root 23100 Feb 28 19:14 /usr/share/licenses/openvkl/third-party-programs-OSPRay.txt -rw-r--r-- 1 root root 15991 Feb 28 19:14 /usr/share/licenses/openvkl/third-party-programs-TBB.txt -rw-r--r-- 1 root root 36021 Feb 28 19:14 /usr/share/licenses/openvkl/third-party-programs.txt $ rpm -q -lv -p ../RPMS/x86_64/openvkl-devel-1.3.2-1.fc39.x86_64.rpm drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/include/openvkl -rw-r--r-- 1 root root 404 Feb 28 19:14 /usr/include/openvkl/VKLBackgroundUndefined.h -rw-r--r-- 1 root root 2630 Feb 28 19:14 /usr/include/openvkl/VKLDataType.h -rw-r--r-- 1 root root 688 Feb 28 19:14 /usr/include/openvkl/VKLError.h -rw-r--r-- 1 root root 722 Feb 28 19:14 /usr/include/openvkl/VKLFilter.h -rw-r--r-- 1 root root 745 Feb 28 19:14 /usr/include/openvkl/VKLFormat.h -rw-r--r-- 1 root root 399 Feb 28 19:14 /usr/include/openvkl/VKLLogLevel.h -rw-r--r-- 1 root root 862 Feb 28 19:14 /usr/include/openvkl/VKLTemporalFormat.h -rw-r--r-- 1 root root 1250 Feb 28 19:14 /usr/include/openvkl/common.h -rw-r--r-- 1 root root 388 Feb 28 19:14 /usr/include/openvkl/common.isph -rw-r--r-- 1 root root 1103 Feb 28 19:14 /usr/include/openvkl/data.h -rw-r--r-- 1 root root 1746 Feb 28 19:14 /usr/include/openvkl/device.h -rw-r--r-- 1 root root 200 Feb 28 19:14 /usr/include/openvkl/device.isph -rw-r--r-- 1 root root 3838 Feb 28 19:14 /usr/include/openvkl/ispc_cpp_interop.h -rw-r--r-- 1 root root 9678 Feb 28 19:14 /usr/include/openvkl/iterator.h -rw-r--r-- 1 root root 11506 Feb 28 19:14 /usr/include/openvkl/iterator.isph -rw-r--r-- 1 root root 1101 Feb 28 19:14 /usr/include/openvkl/max_iterator_size.h -rw-r--r-- 1 root root 240 Feb 28 19:14 /usr/include/openvkl/module.h -rw-r--r-- 1 root root 2114 Feb 28 19:14 /usr/include/openvkl/observer.h -rw-r--r-- 1 root root 484 Feb 28 19:14 /usr/include/openvkl/openvkl.h -rw-r--r-- 1 root root 288 Feb 28 19:14 /usr/include/openvkl/openvkl.isph -rw-r--r-- 1 root root 1096 Feb 28 19:14 /usr/include/openvkl/parameters.h -rw-r--r-- 1 root root 5816 Feb 28 19:14 /usr/include/openvkl/sampler.h -rw-r--r-- 1 root root 8098 Feb 28 19:14 /usr/include/openvkl/sampler.isph -rw-r--r-- 1 root root 7741 Feb 28 19:14 /usr/include/openvkl/types.h drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/include/openvkl/utility drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/include/openvkl/utility/temporal_compression -rw-r--r-- 1 root root 4385 Feb 28 19:14 /usr/include/openvkl/utility/temporal_compression/douglas_peucker.h drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/include/openvkl/utility/usda -rw-r--r-- 1 root root 3319 Feb 28 19:14 /usr/include/openvkl/utility/usda/usda.h drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/include/openvkl/utility/vdb -rw-r--r-- 1 root root 5796 Feb 28 19:14 /usr/include/openvkl/utility/vdb/InnerNodes.h -rw-r--r-- 1 root root 19788 Feb 28 19:14 /usr/include/openvkl/utility/vdb/OpenVdbGrid.h -rw-r--r-- 1 root root 30482 Feb 28 19:14 /usr/include/openvkl/utility/vdb/VdbVolumeBuffers.h drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/include/openvkl/vdb -rw-r--r-- 1 root root 10334 Feb 28 19:14 /usr/include/openvkl/vdb.h -rw-r--r-- 1 root root 5883 Jun 5 02:00 /usr/include/openvkl/vdb/topology.h -rw-r--r-- 1 root root 5877 Jun 5 02:00 /usr/include/openvkl/vdb/topology_1.h -rw-r--r-- 1 root root 5871 Jun 5 02:00 /usr/include/openvkl/vdb/topology_2.h -rw-r--r-- 1 root root 5863 Jun 5 02:00 /usr/include/openvkl/vdb/topology_3.h -rw-r--r-- 1 root root 218 Jun 5 02:00 /usr/include/openvkl/version.h -rw-r--r-- 1 root root 1658 Feb 28 19:14 /usr/include/openvkl/volume.h -rw-r--r-- 1 root root 937 Feb 28 19:14 /usr/include/openvkl/volume.isph drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib64/cmake/openvkl-1.3.2 -rw-r--r-- 1 root root 1753 Jun 5 02:00 /usr/lib64/cmake/openvkl-1.3.2/openvklConfig.cmake -rw-r--r-- 1 root root 2762 Jun 5 02:00 /usr/lib64/cmake/openvkl-1.3.2/openvklConfigVersion.cmake -rw-r--r-- 1 root root 3614 Jun 5 02:00 /usr/lib64/cmake/openvkl-1.3.2/openvkl_Exports-release.cmake -rw-r--r-- 1 root root 5865 Jun 5 02:00 /usr/lib64/cmake/openvkl-1.3.2/openvkl_Exports.cmake lrwxrwxrwx 1 root root 15 Jun 5 02:00 /usr/lib64/libopenvkl.so -> libopenvkl.so.1 lrwxrwxrwx 1 root root 33 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device.so -> libopenvkl_module_cpu_device.so.1 lrwxrwxrwx 1 root root 36 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_16.so -> libopenvkl_module_cpu_device_16.so.1 lrwxrwxrwx 1 root root 35 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_4.so -> libopenvkl_module_cpu_device_4.so.1 lrwxrwxrwx 1 root root 35 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_8.so -> libopenvkl_module_cpu_device_8.so.1 File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/openvkl-1.3.2-1.fc39.x86_64.rpm | sort -f | uniq -c 1 glibc >= 2.37.9000-10 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.32)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libc.so.6(GLIBC_2.38)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libembree4.so.4()(64bit) 1 libgcc_s.so.1()(64bit) 1 libgcc_s.so.1(GCC_3.0)(64bit) 1 libgcc_s.so.1(GCC_3.3.1)(64bit) 1 libm.so.6()(64bit) 1 libm.so.6(GLIBC_2.2.5)(64bit) 1 libm.so.6(GLIBC_2.27)(64bit) 1 libm.so.6(GLIBC_2.29)(64bit) 1 libopenvdb.so.10.0()(64bit) 1 libopenvkl.so.1()(64bit) 1 librkcommon.so.1()(64bit) 1 libstdc++.so.6()(64bit) 1 libstdc++.so.6(CXXABI_1.3)(64bit) 1 libstdc++.so.6(CXXABI_1.3.13)(64bit) 1 libstdc++.so.6(CXXABI_1.3.3)(64bit) 1 libstdc++.so.6(CXXABI_1.3.8)(64bit) 1 libstdc++.so.6(CXXABI_1.3.9)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.11)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.14)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.15)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.18)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.19)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.20)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.21)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.22)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.26)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.29)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.30)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.32)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.5)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.9)(64bit) 1 libtbb.so.2()(64bit) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) $ rpm -q --requires -p ../RPMS/x86_64/openvkl-devel-1.3.2-1.fc39.x86_64.rpm | sort -f | uniq -c 1 cmake-filesystem(x86-64) 1 libopenvkl.so.1()(64bit) 1 libopenvkl_module_cpu_device.so.1()(64bit) 1 libopenvkl_module_cpu_device_16.so.1()(64bit) 1 libopenvkl_module_cpu_device_4.so.1()(64bit) 1 libopenvkl_module_cpu_device_8.so.1()(64bit) 1 openvkl(x86-64) = 1.3.2-1.fc39 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 FIX: Run-require "openvdb-devel >= 7.0.0" by openvkl-devel (/usr/include/openvkl/utility/vdb/OpenVdbGrid.h:10). FIX: Run-require "rkcommon-devel >= 1.11.0" by openvkl-devel (/usr/include/openvkl/utility/vdb/VdbVolumeBuffers.h:9). $ rpm -q --provides -p ../RPMS/x86_64/openvkl-1.3.2-1.fc39.x86_64.rpm | sort -f | uniq -c 1 libopenvkl.so.1()(64bit) 1 libopenvkl_module_cpu_device.so.1()(64bit) 1 libopenvkl_module_cpu_device_16.so.1()(64bit) 1 libopenvkl_module_cpu_device_4.so.1()(64bit) 1 libopenvkl_module_cpu_device_8.so.1()(64bit) 1 openvkl = 1.3.2-1.fc39 1 openvkl(x86-64) = 1.3.2-1.fc39 $ rpm -q --provides -p ../RPMS/x86_64/openvkl-devel-1.3.2-1.fc39.x86_64.rpm | sort -f | uniq -c 1 cmake(openvkl) = 1.3.2 1 openvkl-devel = 1.3.2-1.fc39 1 openvkl-devel(x86-64) = 1.3.2-1.fc39 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/openvkl{,-devel}-1.3.2-1.fc39.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 39 (https://koji.fedoraproject.org/koji/taskinfo?taskID=101834461). Ok. Otherwise, the package is in line with Fedora and CMake packaging guidelines. Please correct the FIX items and provide a new spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2179404 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
