https://bugzilla.redhat.com/show_bug.cgi?id=2106138 Felix Kaechele <felix@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felix@xxxxxxxxxxx --- Comment #5 from Felix Kaechele <felix@xxxxxxxxxxx> --- For the Source URL, since this is hosted on GitHub check out this: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_tag_example As for the examples: For the packages I've been maintaining I default to installing the configuration examples into the proper configuration location (i.e. /etc aka %{_sysconfdir}). Ideally the software is able to run without any user intervention using some reasonable defaults with that configuration. In this package you include both a config and a systemd unit as examples. Technically you should include them at their proper location such that the user can immediately launch the service after they installed it. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/#unit_files In your case this would mean correctly configuring the path to the executable in the systemd unit: ExecStart=/home/youruser/virtual-environment/bin/pinnwand --configuration-path /home/youruser/pinnwand.toml http would become something like: ExecStart=/usr/bin/pinnwand --configuration-path /etc/pinnwand/pinnwand.toml http and then installing the configuration to %{_sysconfdir}/pinnwand as well as putting it into the files section as %dir %{_sysconfdir}/%{name} %config(noreplace) %{_sysconfdir}/%{name}/%{name}.toml -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2106138 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
