https://bugzilla.redhat.com/show_bug.cgi?id=2210561 --- Comment #2 from Daniel Milnes <daniel@xxxxxxxxxxxxxxxx> --- Hey Maxwell, Thank you so much for all your feedback. I really appreciate all of it, and hopefully I've just pushed a release which fixes all your concerns: Updated SRPM: https://download.copr.fedorainfracloud.org/results/thebeanogamer/hstsparser/fedora-rawhide-x86_64/06000907-hstsparser/hstsparser-1.1.8-4.fc39.src.rpm * poetry -> poetry-core This was a holdover from when I was working on this project prior to Poetry 1.1 splitting that out. I've switched it all over to poetry-core now. * Version pin for Python This is because pyinstaller (which is used for building the Windows release) has a max Python version set. I've moved that into an environment marker, so the Python version for anything non-Windows is now unconstrained. Is there a way for me to test building against Python 3.12 yet? * Version pin for PrettyTable I think I added this whilst fighting Poetry. Every distro seems to have stuck on prettytable 0.7.2 for a long time, then Fedora 39 is using 3.6.0. I've removed this and it still builds on 38 and 39 so I think it's all fine. * RPM group, tox, & manual BuildRequires I've removed these * Man page building As requested, I've moved the build to %build and now just install the file in %install. * Comment about venv Sorry, re-reading this I understand the confusion. I've updated the comment in the spec file, but to give a bit more detail: hstsparser is using `importlib.metadata` to find the value for `--version` when `help2man` asks for it. However as `hstsparser` is not actually installed in the buildroot, this fails to find and gives a default value. To work around this, I'm manually telling `help2man` what the version is. * formatting I've spent some time tidying this up. Hopefully that covers all your concerns, but if there's anything else please let me know and I'd be delighted to fix it. Thanks again. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2210561 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
