https://bugzilla.redhat.com/show_bug.cgi?id=2166379 Josh Stone <jistone@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jistone@xxxxxxxxx | |m) | --- Comment #28 from Josh Stone <jistone@xxxxxxxxxx> --- I haven't done a formal review in a while, hope I'm doing this right... Only two easy things that I see to fix, otherwise LGTM! Package Review ============== Summary: * MUST: install cloudlibc/LICENSE * SHOULD: justify the patch Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [!]: License file installed when any subpackage combination is installed. jistone: Missing an installed libc-bottom-half/cloudlibc/LICENSE (will need a rename on install to not clobber the root LICENSE) [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [-]: Package contains no bundled libraries without FPC exception. Note: considering N/A because system libraries don't apply to WASI. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). jistone: these look fine to me [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: wasi-libc-static. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in wasi- libc-static , wasi-libc-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. jistone: only one patch, but has no comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: wasi-libc-static-20-1.fc39.noarch.rpm wasi-libc-devel-20-1.fc39.noarch.rpm wasi-libc-20-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpk8zfks_o')] checks: 31, packages: 3 wasi-libc-devel.noarch: E: zero-length /usr/wasm32-wasi/include/bits/hwcap.h wasi-libc-devel.noarch: E: zero-length /usr/wasm32-wasi/include/bits/io.h wasi-libc-devel.noarch: E: zero-length /usr/wasm32-wasi/include/bits/ioctl_fix.h wasi-libc-devel.noarch: E: zero-length /usr/wasm32-wasi/include/bits/mman.h wasi-libc-devel.noarch: E: zero-length /usr/wasm32-wasi/include/bits/poll.h wasi-libc-devel.noarch: E: zero-length /usr/wasm32-wasi/include/bits/resource.h wasi-libc-devel.noarch: E: zero-length /usr/wasm32-wasi/include/bits/socket.h wasi-libc-static.noarch: W: files-duplicate /usr/wasm32-wasi/lib/wasm32-wasi/crt1.o /usr/wasm32-wasi/lib/wasm32-wasi/crt1-command.o wasi-libc-static.noarch: W: files-duplicate /usr/wasm32-wasi/lib/wasm32-wasi/libxnet.a /usr/wasm32-wasi/lib/wasm32-wasi/libcrypt.a:/usr/wasm32-wasi/lib/wasm32-wasi/libdl.a:/usr/wasm32-wasi/lib/wasm32-wasi/libm.a:/usr/wasm32-wasi/lib/wasm32-wasi/libpthread.a:/usr/wasm32-wasi/lib/wasm32-wasi/libresolv.a:/usr/wasm32-wasi/lib/wasm32-wasi/librt.a:/usr/wasm32-wasi/lib/wasm32-wasi/libutil.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/libc-printscan-long-double.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/libc-printscan-no-floating-point.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/libc.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/libcrypt.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/libdl.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/libm.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/libpthread.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/libresolv.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/librt.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/libutil.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/libwasi-emulated-getpid.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/libwasi-emulated-mman.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/libwasi-emulated-process-clocks.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/libwasi-emulated-signal.a wasi-libc-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/wasm32-wasi/lib/wasm32-wasi/libxnet.a 3 packages and 0 specfiles checked; 22 errors, 2 warnings, 22 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/WebAssembly/wasi-libc//archive/refs/tags/wasi-sdk-20.tar.gz#/wasi-libc-wasi-sdk-20.tar.gz : CHECKSUM(SHA256) this package : 0a1c09c8c1da62a1ba214254ff4c9db6b60979c00f648a5eae33831d6ee2840e CHECKSUM(SHA256) upstream package : 0a1c09c8c1da62a1ba214254ff4c9db6b60979c00f648a5eae33831d6ee2840e Requires -------- wasi-libc-static (rpmlib, GLIBC filtered): wasi-libc-devel (rpmlib, GLIBC filtered): wasi-libc-static Provides -------- wasi-libc-static: bundled(musl) wasi-libc-static wasi-libc-devel: bundled(musl) wasi-libc-devel Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name wasi-libc --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Java, PHP, Ocaml, R, C/C++, Python, SugarActivity, fonts, Perl, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2166379 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
