https://bugzilla.redhat.com/show_bug.cgi?id=2174100 Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(michel@michel-slm | |.name) | --- Comment #3 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- (In reply to blinxen from comment #2) > Taking this review > > General comments: > > - Package was generated with rust2rpm and no modifications were done > - joinery is already packaged for fedora. This is probably a compat package > that is required for building nushell :D ? > > Issues: > > - Some files have incorrect end-of-line encoding, see rpmlint > Sorry for the delay! Yes, this is a compat crate so does not even really require a review now, but reviews always help surface these nits. Will get them fixed soon. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2174100 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue