https://bugzilla.redhat.com/show_bug.cgi?id=2187797 --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks for the review! (In reply to blinxen from comment #3) > Taking this review > > General comments: > > - Package was generated with rust2rpm and a feature was removed > - Feature appears to be unstable, so I guess this is OK The removed features are gated behind a custom `--cfg` flag, which needs to be passed as RUSTFLAGS="--cfg tracing_unstable" environment variable, which is not supported for RPM builds, so removing them is the only sensible thing we can do. > - Tests were deactivated because they rely on an unpublished crate. I guess > this is OK but what is normally done here? Should this be reported to > upstream? I don't think this is useful to report to upstream. They choose not to publish the crate that's needed to run the tests, so there's not much we can do. > - Version 0.3.17 was published I will update the package before I import it. > APPROVED Thanks! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2187797 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
